Browse Source

Made the pass classes sealed, which is a more sensible way to please the compiler about using virtual methods inside constructors.

framework
Nico de Poel 2 years ago
parent
commit
43e0f15ab8
  1. 2
      Runtime/Common/FfxPassBase.cs
  2. 16
      Runtime/FSR2/Fsr2Pass.cs
  3. 22
      Runtime/FSR3/Fsr3UpscalerPass.cs

2
Runtime/Common/FfxPassBase.cs

@ -57,7 +57,7 @@ namespace FidelityFX
Flags = flags;
}
protected sealed override void InitComputeShader(string passName, ComputeShader shader, string kernelName = "CS")
protected override void InitComputeShader(string passName, ComputeShader shader, string kernelName = "CS")
{
base.InitComputeShader(passName, shader, kernelName);
SetupShaderKeywords();

16
Runtime/FSR2/Fsr2Pass.cs

@ -62,7 +62,7 @@ namespace FidelityFX.FSR2
}
}
internal class Fsr2ComputeLuminancePyramidPass : Fsr2Pass
internal sealed class Fsr2ComputeLuminancePyramidPass : Fsr2Pass
{
private readonly ComputeBuffer _spdConstants;
@ -90,7 +90,7 @@ namespace FidelityFX.FSR2
}
}
internal class Fsr2ReconstructPreviousDepthPass : Fsr2Pass
internal sealed class Fsr2ReconstructPreviousDepthPass : Fsr2Pass
{
public Fsr2ReconstructPreviousDepthPass(in Fsr2.ContextDescription contextDescription, Fsr2Resources resources, ComputeBuffer constants)
: base(contextDescription, resources, constants)
@ -113,7 +113,7 @@ namespace FidelityFX.FSR2
}
}
internal class Fsr2DepthClipPass : Fsr2Pass
internal sealed class Fsr2DepthClipPass : Fsr2Pass
{
public Fsr2DepthClipPass(in Fsr2.ContextDescription contextDescription, Fsr2Resources resources, ComputeBuffer constants)
: base(contextDescription, resources, constants)
@ -141,7 +141,7 @@ namespace FidelityFX.FSR2
}
}
internal class Fsr2LockPass : Fsr2Pass
internal sealed class Fsr2LockPass : Fsr2Pass
{
public Fsr2LockPass(in Fsr2.ContextDescription contextDescription, Fsr2Resources resources, ComputeBuffer constants)
: base(contextDescription, resources, constants)
@ -158,7 +158,7 @@ namespace FidelityFX.FSR2
}
}
internal class Fsr2AccumulatePass : Fsr2Pass
internal sealed class Fsr2AccumulatePass : Fsr2Pass
{
private const string SharpeningKeyword = "FFX_FSR2_OPTION_APPLY_SHARPENING";
@ -222,7 +222,7 @@ namespace FidelityFX.FSR2
}
}
internal class Fsr2SharpenPass : Fsr2Pass
internal sealed class Fsr2SharpenPass : Fsr2Pass
{
private readonly ComputeBuffer _rcasConstants;
@ -248,7 +248,7 @@ namespace FidelityFX.FSR2
}
}
internal class Fsr2GenerateReactivePass : Fsr2Pass
internal sealed class Fsr2GenerateReactivePass : Fsr2Pass
{
private readonly ComputeBuffer _generateReactiveConstants;
@ -280,7 +280,7 @@ namespace FidelityFX.FSR2
}
}
internal class Fsr2TcrAutogeneratePass : Fsr2Pass
internal sealed class Fsr2TcrAutogeneratePass : Fsr2Pass
{
private readonly ComputeBuffer _tcrAutogenerateConstants;

22
Runtime/FSR3/Fsr3UpscalerPass.cs

@ -60,7 +60,7 @@ namespace FidelityFX.FSR3
}
}
internal class Fsr3UpscalerPrepareInputsPass : Fsr3UpscalerPass
internal sealed class Fsr3UpscalerPrepareInputsPass : Fsr3UpscalerPass
{
public Fsr3UpscalerPrepareInputsPass(in Fsr3Upscaler.ContextDescription contextDescription, Fsr3UpscalerResources resources, ComputeBuffer constants)
: base(contextDescription, resources, constants)
@ -86,7 +86,7 @@ namespace FidelityFX.FSR3
}
}
internal class Fsr3UpscalerLumaPyramidPass : Fsr3UpscalerPass
internal sealed class Fsr3UpscalerLumaPyramidPass : Fsr3UpscalerPass
{
private readonly ComputeBuffer _spdConstants;
@ -119,7 +119,7 @@ namespace FidelityFX.FSR3
}
}
internal class Fsr3UpscalerShadingChangePyramidPass : Fsr3UpscalerPass
internal sealed class Fsr3UpscalerShadingChangePyramidPass : Fsr3UpscalerPass
{
private readonly ComputeBuffer _spdConstants;
@ -153,7 +153,7 @@ namespace FidelityFX.FSR3
}
}
internal class Fsr3UpscalerShadingChangePass : Fsr3UpscalerPass
internal sealed class Fsr3UpscalerShadingChangePass : Fsr3UpscalerPass
{
public Fsr3UpscalerShadingChangePass(in Fsr3Upscaler.ContextDescription contextDescription, Fsr3UpscalerResources resources, ComputeBuffer constants)
: base(contextDescription, resources, constants)
@ -171,7 +171,7 @@ namespace FidelityFX.FSR3
}
}
internal class Fsr3UpscalerPrepareReactivityPass : Fsr3UpscalerPass
internal sealed class Fsr3UpscalerPrepareReactivityPass : Fsr3UpscalerPass
{
public Fsr3UpscalerPrepareReactivityPass(in Fsr3Upscaler.ContextDescription contextDescription, Fsr3UpscalerResources resources, ComputeBuffer constants)
: base(contextDescription, resources, constants)
@ -199,7 +199,7 @@ namespace FidelityFX.FSR3
}
}
internal class Fsr3UpscalerLumaInstabilityPass : Fsr3UpscalerPass
internal sealed class Fsr3UpscalerLumaInstabilityPass : Fsr3UpscalerPass
{
public Fsr3UpscalerLumaInstabilityPass(in Fsr3Upscaler.ContextDescription contextDescription, Fsr3UpscalerResources resources, ComputeBuffer constants)
: base(contextDescription, resources, constants)
@ -226,7 +226,7 @@ namespace FidelityFX.FSR3
}
}
internal class Fsr3UpscalerAccumulatePass : Fsr3UpscalerPass
internal sealed class Fsr3UpscalerAccumulatePass : Fsr3UpscalerPass
{
private const string SharpeningKeyword = "FFX_FSR3UPSCALER_OPTION_APPLY_SHARPENING";
@ -285,7 +285,7 @@ namespace FidelityFX.FSR3
}
}
internal class Fsr3UpscalerSharpenPass : Fsr3UpscalerPass
internal sealed class Fsr3UpscalerSharpenPass : Fsr3UpscalerPass
{
private readonly ComputeBuffer _rcasConstants;
@ -311,7 +311,7 @@ namespace FidelityFX.FSR3
}
}
internal class Fsr3UpscalerGenerateReactivePass : Fsr3UpscalerPass
internal sealed class Fsr3UpscalerGenerateReactivePass : Fsr3UpscalerPass
{
private readonly ComputeBuffer _generateReactiveConstants;
@ -343,7 +343,7 @@ namespace FidelityFX.FSR3
}
}
internal class Fsr3UpscalerTcrAutogeneratePass : Fsr3UpscalerPass
internal sealed class Fsr3UpscalerTcrAutogeneratePass : Fsr3UpscalerPass
{
private readonly ComputeBuffer _tcrAutogenerateConstants;
@ -378,7 +378,7 @@ namespace FidelityFX.FSR3
}
#if UNITY_EDITOR || DEVELOPMENT_BUILD
internal class Fsr3UpscalerDebugViewPass : Fsr3UpscalerPass
internal sealed class Fsr3UpscalerDebugViewPass : Fsr3UpscalerPass
{
public Fsr3UpscalerDebugViewPass(in Fsr3Upscaler.ContextDescription contextDescription, Fsr3UpscalerResources resources, ComputeBuffer constants)
: base(contextDescription, resources, constants)

Loading…
Cancel
Save